search

Peter-Schorn / SpotifyAPI

A Swift library for the Spotify web API. Supports all endpoints.
https://peter-schorn.github.io/SpotifyAPI/documentation/spotifywebapi
MIT License
251 stars 32 forks source link

Move authorization logging to a shared wrapper class for simpler future use #16

Closed Ivorforce closed 3 years ago

Ivorforce commented 3 years ago

This diverges a slight bit from your corresponding changes, but not by much.

Peter-Schorn commented 3 years ago

I don't want to merge this change into master. Instead, we should continue to work on the proxy-tokens-server branch. Eventually, when the this branch is production-ready, I will merge it into master, and bump the version to 2.0.0.

Ivorforce commented 3 years ago

I understand your concern, but breaking down huge merge requests is a good way to avoid mistakes. I'd strongly advise against merging everything in a big-bang merge.

By separating reformats, interface changes, and behavior changes specifically, you can merge some of these without risk. This PR specifically is a mere reformat and is mergable without bumping the major version.

Peter-Schorn commented 3 years ago

The authorization managers in proxy-tokens-server are sufficiently different from master that I don't think it makes sense to merge changes to them into master piecemeal. This is something that must be done all at once. Also, I haven't even started on the documentation for the authorization managers.