search

Peter-Schorn / SpotifyAPI

A Swift library for the Spotify web API. Supports all endpoints.
https://peter-schorn.github.io/SpotifyAPI/documentation/spotifywebapi
MIT License
269 stars 33 forks source link

Remove SpotifyExampleContent from SpotifyAPI in Swift Package #45

Closed gregggreg closed 6 months ago

gregggreg commented 1 year ago

If you include SpotifyAPI using Swift Package Manager, it includes the SpotifyExampleContent in your resulting app, adding several megabytes of unused content into your app. I've removed it from my fork and would love to see it merged so that I don't have to rely on my fork. Thanks, this project is super useful.

gregggreg commented 1 year ago

here is the pull request:

https://github.com/Peter-Schorn/SpotifyAPI/pull/46

will-lumley commented 1 year ago

+1, I just checked also and it's adding 4.8MB to my app 😱 @Peter-Schorn Are there any plans to spin off the SpotifyExampleContent into its own library that can then be pulled into SpotifyAPI when necessary? Happy to help out / work on it.

Peter-Schorn commented 1 year ago

I would accept a PR that moves SpotifyExampleContent into a separate library.

Peter-Schorn commented 7 months ago

Implemented in latest commit. Will be availble in next release.

Peter-Schorn commented 6 months ago

Implemented in version 3.0.0.