search

Peter-Schorn / SpotifyAPIExampleApp

An Example App that demonstrates the usage of SpotifyAPI.
23 stars 8 forks source link

Make the app shows the top tracks, artists, and recently played tra… #4

Closed usamaeltmsah closed 2 years ago

usamaeltmsah commented 2 years ago

Make the app show the top tracks, top artists, and recently played tracks for the Spotify user.

Peter-Schorn commented 2 years ago

I'm only going to merge the minimal amount of changes necessary. I'm not going to rename my entire project to "Topotify". You can't be serious.

usamaeltmsah commented 2 years ago

Thanks, Peter, for your response. I got your point, and I will review the code.

On Sat, Jul 23, 2022 at 11:20 PM Peter Schorn @.***> wrote:

@.**** commented on this pull request.

In Topotify/Views/TabBarViews/TopArtistsView.swift https://github.com/Peter-Schorn/SpotifyAPIExampleApp/pull/4#discussion_r928166087 :

+// Topotify +// +// Created by Usama Fouad on 23/07/2022. +// + +import SwiftUI +import Combine +import SpotifyWebAPI +import SpotifyExampleContent + + +struct TopArtistsView: View { +

  • @EnvironmentObject var spotify: Spotify
  • @State private var topArtists: [Artist]

Just set the initial value at the declaration site and get rid of the initializer.

— Reply to this email directly, view it on GitHub https://github.com/Peter-Schorn/SpotifyAPIExampleApp/pull/4#pullrequestreview-1048570185, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFSMAWNP5NGGQBQOVMB2GVDVVROZ5ANCNFSM54OIRISQ . You are receiving this because you authored the thread.Message ID: @.***>