search

Peter554 / StainTools

Tools for tissue image stain normalisation and augmentation in Python 3
MIT License
321 stars 107 forks source link

Move RJ to normalizers #10

Closed jgamper closed 6 years ago

jgamper commented 6 years ago

oy @Peter554 ! Can I move RJ to normalizers from the augmentors?

Peter554 commented 6 years ago

It depends if the RJ method is really a normalizer i.e. can it be implemented with a fit and transform method like the other normalisers?

jgamper commented 6 years ago

Yes, you right - its just a stain deconvolution method. Not sure where to put it, what about moving rj to utils.rj_utils as I tried in this branch of my fork LINK, and then modified augmentors.Fetcher as such LINK

Let me know what you think boss!

Peter554 commented 6 years ago

Yes we can merge that in for sure ;)

jgamper commented 6 years ago

Pull request #12 , please review, merge if appropriate and close 💃

Peter554 commented 6 years ago

Merged :D