search

PeterBorah / vigor

An unofficial ruby wrapper for the League of Legends API
MIT License
4 stars 4 forks source link

Refactor Game.fellow_players to include all players? #17

Open PeterBorah opened 10 years ago

PeterBorah commented 10 years ago

Riot's Game API is designed such that it lists information for the player you searched for on the game object itself, and then leaves that player out of fellowPlayers. Should we hide this fact, and just embed the searched-for player in the list of players?

imogenkinsman commented 10 years ago

Makes sense to me - I don't think a game should necessarily be associated with a player, so maybe there should be a game#players instead that shows all players that were in the game.