search

PeterCat12 / pysmash

A python wrapper to smash.gg Developer API
22 stars 11 forks source link

Api updates #43

Closed LuNoX closed 6 years ago

LuNoX commented 7 years ago

Just wanted to know if you're gonna bring the wrapper up to date with the Smash.gg API changes or if this repo is gonna be dead.

PeterCat12 commented 7 years ago

Hey @LuNoX,

No, this repo is not dead. I still use it for a project with Panda Global. I wasn't aware of any API changes with Smash.gg but I have been out of the loop for awhile. What changes are you referring to?

PeterCat12 commented 7 years ago

@LuNoX I have time this Sunday (10/15/2017) and the weekend after to bring some stuff up to date. If you'd like to write out a list of features/changes you'd like addressed that would be greatly appreciated.

LuNoX commented 7 years ago

A few months ago my bot just stopped working without any code changes, so I did some digging and found the pysmash methods to be returning wrong data. When investigating the issue further I found that Smash.gg had started updating their API. I don't know the changes in particular just that they definitely changed some stuff.

LuNoX commented 7 years ago

@PeterCat12 I'll try and get a list of features until next week. Kinda busy at the moment :/

It's cool that you're this active though :)

PeterCat12 commented 7 years ago

@LuNoX Thanks.

Apologies for never reviewing or addressing your PR. Life just kind of got in the way. I've been planning on a second big push with features soon with my smash4 app which would include changes/updates to this repo.

I will run this repo's test suite and see if anything is super broken. As far as I know though, my smash4 app has been working (mostly) correctly. Smash.gg does have a tendency to change random shit without warning though :(

LuNoX commented 7 years ago

@PeterCat12 you did review my PR and told me to go and write tests which I never did cause I'm lazy.

Yeah, sadly.

PeterCat12 commented 7 years ago

haha damn. Well, I'll look into introducing some CI to this repo over the weekend. See if we can't merge that bad boy in :)

PeterCat12 commented 6 years ago

Closing issue as the subsequent PR has been closed.