Use date instead of ls to find modification time

PeterDaveHello / web-minify-helper

Help web developer to make their js & css files minified easily!

14 stars 14 forks source link

Use date instead of ls to find modification time #13

Closed kemayo closed 7 years ago

kemayo commented 8 years ago

Current ls-based modification detection fails on OSX, unless you've installed a newer version of ls. We can make this work on OSX 10.10 or newer without requiring updated coreutils, if we just do date -r for the modification time.

PeterDaveHello commented 8 years ago

Thanks @kemayo, that's fair enough, may I confirmed that if you have tested on FreeBSD and some Linux distros? Thanks again!

kemayo commented 8 years ago

I tried it on Ubuntu as well as OSX. Give me a second to dig up something running FreeBSD so I can double-check there.

kemayo commented 8 years ago

I have confirmed with FreeBSD, via vagrant. I also confirmed on CentOS, since I had that lying around.

PeterDaveHello commented 8 years ago

Awesome @kemayo ! I'll review the codes and also test it from my side, if there is no more questions or any problems, I'll merge this, thanks!

PeterDaveHello commented 7 years ago

@kemayo sorry for the late reply, I turned to use base -ot to help compare the timestamp in a easier way in commit: https://github.com/PeterDaveHello/web-minify-helper/commit/ac24c5a118688822aa59f8fc2b576f24eaa0c79a, still thanks for your contribution!