PeterHuewe / tpm-emulator

The famous tpm-emulator by Mario Strasser, previously hosted on BerliOs. It supports TPM1.2 only!
GNU General Public License v2.0
177 stars 75 forks source link

tpmd_dev: remove size parameter from sock_recvmsg #15

Closed jjmcdn closed 7 years ago

jjmcdn commented 8 years ago

In Linux 4.7 the 'size' parameter was dropped from sock_recvmsg(). Accommodate pre- and post-4.7 kernel builds.

Signed-off-by: Joe MacDonald joe_macdonald@mentor.com

PeterHuewe commented 8 years ago

Hi, did you test this? I think you have to also have to initialize the

see Issue #14

Would be great if you can test/comment on it.

jjmcdn commented 8 years ago

I am testing it right now, I'll follow up soon.

On Fri, Oct 14, 2016 at 10:41 AM, Peter Huewe notifications@github.com wrote:

Hi, did you test this? I think you have to also have to initialize the

  • iov_iter_init(&msg.msg_iter, WRITE, &iov, 1, 1);
  • iov_iter_init(&msg.msg_iter, WRITE, &iov, 1, tpm_response.size); differently ?

see Issue #14 https://github.com/PeterHuewe/tpm-emulator/issues/14

Would be great if you can test/comment on it.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/PeterHuewe/tpm-emulator/pull/15#issuecomment-253819489, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEi0efwziCVG_K1YaO1XziAsSNtfDb8ks5qz5R-gaJpZM4KXEYh .

Joe MacDonald :wq

PeterHuewe commented 7 years ago

@joeythesaint Did you test this?

theopolis commented 7 years ago

I've tested this and it's not working, the driver is only replying with 1 byte. Seems you definitely need the iov_iter_init change.

PeterHuewe commented 7 years ago

Thanks for your work but I guess #21 is more suitable