PeterJCLaw / srcomp-cli

Command line tools for interacting with the state of the Student Robotics Competition
https://github.com/PeterJCLaw/srcomp/wiki
0 stars 2 forks source link

Observe which teams have already dropped out when extending the league schedule #26

Closed PeterJCLaw closed 1 year ago

PeterJCLaw commented 1 year ago

I'm pretty sure, but haven't checked, that when extending a league schedule we'll try to match up all the teams in the compstate to places in the new schedule. However if there are dropped out teams that may not be what we want to actually happen.

I'm not sure what the right behaviour is here (include or not include dropped out teams), which suggests that an option (rather than only doing one or the other) might be the way to go.

PeterJCLaw commented 1 year ago

This was already handled. Docs clarified in ffd56b38b23df433ca3254c106eb99e4dba6a93a.

The relevant code is https://github.com/PeterJCLaw/srcomp-cli/blob/ffd56b38b23df433ca3254c106eb99e4dba6a93a/sr/comp/cli/import_schedule/loading.py#L53-L69