search

PeterJCLaw / srcomp-http

Web API to the state of the Student Robotics Competition
https://github.com/PeterJCLaw/srcomp/wiki
GNU General Public License v3.0
0 stars 4 forks source link

Fixes flask errors where 402 is not a HTTP code #2

Closed Tyler-Ward closed 5 years ago

PeterJCLaw commented 5 years ago

@Tyler-Ward thanks, I didn't even realise this was an issue. Presumably this was caused by a change in Flask so that invalid error codes are now rejected?

Tyler-Ward commented 5 years ago

From what myself and Mohit can tell Flask has removed error codes that are not standardized meaning mapping all error codes to our handler generates errors on any which don't exist.

PeterJCLaw commented 5 years ago

@Tyler-Ward thanks! I'm happy to merge this ignoring the CI failure (which is unrelated). I'm in the process of sorting out a formal licensing situation for this repo, ideally I'd like to go with something like MIT or BSD 3-Clause, though it's looking likely we'll end up with GPLv3. Would you be ok with your contribution being under those licenses?

Tyler-Ward commented 5 years ago

MIT and BSD sound good to me.

PeterJCLaw commented 5 years ago

@Tyler-Ward thanks for your contribution though unfortunately as I think there's a strong likelihood we're going to need to license this under GPL (due to the preferences of one of the existing contributors) I don't think I'm going to be able to merge this.