PeterJCLaw / srcomp-kiosk

A puppet config for setting up a number of Raspberry Pis as kisok-mode browsers
https://github.com/PeterJCLaw/srcomp/wiki/Component-Overview#srcomp-kiosk
MIT License
0 stars 3 forks source link

Move kiosk to systemd service #24

Open WillB97 opened 1 year ago

WillB97 commented 1 year ago

Uses systemd directly to start and restart the browser. Adds options for running livestream and using chromium on low-end devices.

Drops support for Firefox.

PeterJCLaw commented 1 year ago

Thanks for this contribution, however in future I would strongly advise discussing changes of this scale before starting development. While some of the changes here may be applicable, there are also a number of changes here which I don't think are desirable.

I'm guessing that with moving systemd you're hoping to address some of the process management issues that have been observed (https://github.com/PeterJCLaw/srcomp-kiosk/issues/21, https://github.com/PeterJCLaw/srcomp-kiosk/issues/8)? Those would indeed be great to resolve, so if that's the case it would be great to know if they are addressed here.

However, I anticipate that moving to systemd has a number of other knock-on effects. It's not immediately clear what those are nor whether or not they are desirable. (Forcing the control of the service to require sudo being one thing that comes to mind).

There are some useful things here though:

I would be happy to discuss these changes, however I would rather not merge them as a single PR.

I would also encourage in future that you self-review the commits before submitting them -- many of the commits here are missing details regarding the intent of their changes and/or contain extraneous changes unrelated to those described. This makes it both harder to review the changes and makes the history much less useful for future developers.