search

PeterJCLaw / srcomp-stream

SRComp live streaming server
https://github.com/PeterJCLaw/srcomp/wiki/Component-Overview#srcomp-stream
MIT License
0 stars 1 forks source link

Memory leak #5

Open PeterJCLaw opened 3 years ago

PeterJCLaw commented 3 years ago

We've noticed in the past, and especially during this year's virtual competition, that the stream seems to fall over if left to run for a while. The timescales involved are ~days, so we don't see this at the actual competition (where the compbox is live for a weekend and the one in the venue is usually powered down overnight anyway), however this is becoming an issue for the public compbox, which needs poking before each league session.

There's evidence from the logs that it's being killed by the OOM-killer, though of course that doesn't necessarily mean that it's the culprit. It does seem relatively likely though given the relative shonkiness of this piece of the stack.

PeterJCLaw commented 3 years ago

Having watched the process since I restarted it over the weekend, the stream's memory usage has grown from ~6% of that available on the system (which has 1GB RAM available) to ~23%. This seems fairly conclusive that there's a memory leak here.

PeterJCLaw commented 3 years ago

Since we now have this a bit more handled (https://github.com/PeterJCLaw/srcomp-puppet/pull/18) I'm not looking into this specifically any more. Would still be great to fix, though we are also considering rewriting the stream so it may just become moot.