search

PeterL1n / BackgroundMattingV2

Real-Time High-Resolution Background Matting
MIT License
6.81k stars 950 forks source link

support CPU for inference_images.py #26

Closed jinzishuai closed 3 years ago

PeterL1n commented 3 years ago

Thanks for your contribution.

Are you able to modify it so that num_workers is not hardcoded in the file? Make it a command line argument --num-workers after line 56. Set its default to 0, but allow people to change it.

If you don't have time, I will make the change myself later.

jinzishuai commented 3 years ago

sure, I would be happy to do that but that would be a separate PR since this one is just about the CPU support.

jinzishuai commented 3 years ago

Thanks for your contribution.

Are you able to modify it so that num_workers is not hardcoded in the file? Make it a command line argument --num-workers after line 56. Set its default to 0, but allow people to change it.

If you don't have time, I will make the change myself later.

@PeterL1n this is the PR https://github.com/PeterL1n/BackgroundMattingV2/pull/28. please review. thanks.

PeterL1n commented 3 years ago

Merged the other pull request. I am closing this one.