PeterLemon / RaspberryPi

Raspberry Pi Bare Metal Assembly Programming
450 stars 66 forks source link

Issues with looping video when creating custom lz format video #22

Open apkatsikas opened 1 year ago

apkatsikas commented 1 year ago

Hi @PeterLemon! it took me many years to give this a try, but now that i am a more confident and experienced programmer, i got it running!

https://www.youtube.com/watch?v=S8icTC9zRAc

My only issue is it does not loop and then it freezes, whereas your example loops forever (desired behavior for me as well).

My process is here:

https://github.com/apkatsikas/pi-video

When i open my concat-ed lz file, it looks like this: image

notably, mine shows only 1 element of 159, vs. your files 5. also of note, i only used 155 frames for this animation, so im not sure where the other 4 are coming from. i also noticed your starts with a few test frames, it looks like, whereas mine does not.

Other things to consider:

I could process my array differently like this https://github.com/apkatsikas/pi-video/blob/fc316f29794ba68453592231e06337367fa3cc68/process.py#L10

I could specify a different length, byte order or signed options https://github.com/apkatsikas/pi-video/blob/fc316f29794ba68453592231e06337367fa3cc68/process.py#L45

I could write bytes more like this https://github.com/apkatsikas/pi-video/blob/fc316f29794ba68453592231e06337367fa3cc68/process.py#L50

apkatsikas commented 1 year ago

could it have to do with this line? https://github.com/PeterLemon/RaspberryPi/blob/5783e31ba16353413a9248431da464e37a5619d1/Video/GRBLZVideo/kernel.asm#L35

im also curious how your 656 frames is represented here as 615.