search

PeterMosmans / ansible-role-customize-gnome

Ansible role that customizes the GNOME desktop. It installs fonts and GNOME extensions from packages or zip files, copies files like desktop backgrounds and GNOME shell tweaks to a host, and modifies user settings.
GNU General Public License v3.0
74 stars 20 forks source link

9 gsettings set does not work for manually installed extensions #10

Closed ctorgalson closed 2 years ago

ctorgalson commented 2 years ago

This change makes it possible for the gsettings set command in the main tasks file to include the --schemadir option. This is needed, for example, for setting preferences on newly or manually installed extensions.

When a loop item does not include the schemadir key, the task operates as it does now.

It might have been better to use |ternary() instead of jinja2's {% if ... %}...{% endif %}, but even using the same condition, it didn't work in my testing.

@see PeterMosmans/ansible-role-customize-gnome/issues/9

ctorgalson commented 2 years ago

I should rtfiq (read-the-f-issue-queue) :D

I see that there is already a PR that's essentially identical to this one (#5), so closing here.

(Also, for anyone coming upon this as the result of a search, the dconf command can be simpler than gsettings anyhow).

PeterMosmans commented 2 years ago

@ctorgalson unsure if you've seen it, but I merged #5 - thanks for your contributions nevertheless :)