search

PeterMosmans / ansible-role-virtualbox-guest

Ansible role for building and installing VirtualBox guest additions
GNU General Public License v3.0
20 stars 22 forks source link

Updated to support VBox Guest Addtion for RHEL family #15

Closed tin6150 closed 7 years ago

tin6150 commented 7 years ago

Peter, please have a look at this. It works for me for CentOS 7 guest, executed from Ubuntu and CentOS host.

PeterMosmans commented 7 years ago

Hi @tin6150 - thanks for your pull request, much appreciated! Would you mind removing the remarked lines ? That makes a somewhat more cleaner look. People can always see them (back) in the history :wink:

And, would you mind removing the reference to this fork in the README.md ? That's superfluous :wink:

If you want I could also do these changes by editing your PR.

Thanks once again,

Peter

tin6150 commented 7 years ago

How does that look now? ;-) package support less argument than apt at this point, I left some of your apt arguments as comments in case they raise some strange bugs and you really have to put them back... I didn't test on ubuntu guest.
Thanks! Tin

PeterMosmans commented 7 years ago

Thanks Tin for your PR and changes :thumbsup:

Cheers,

Peter