PeterMosmans / ansible-role-virtualbox-guest

Ansible role for building and installing VirtualBox guest additions
GNU General Public License v3.0
20 stars 22 forks source link

Add support to copy local iso into host #26

Closed df3l0p closed 4 years ago

PeterMosmans commented 4 years ago

Great addition, thanks! I really appreciate the extension!

However, since the local_virtualbox_iso is added to the defaults file, this will always be true for users. IMHO it makes more sense to not add it to the defaults file, so that it will only be TRUE when manually added. Could you also add this option to the README.md file? Thanks again!

PeterMosmans commented 4 years ago

Hi @df3l0p - can you take another look at the PR and my comments? Thanks!

df3l0p commented 4 years ago

Hey @PeterMosmans, sorry about the delay. Here are the changes. LMKWYT

PeterMosmans commented 4 years ago

Thanks again @df3l0p !