search

PeterMosmans / openssl

'Extra featured' OpenSSL with ChaCha20 and Poly1305 support
https://onwebsecurity.com/pages/openssl.html
Other
92 stars 18 forks source link

1.0.2 is stable now :) #4

Closed splitice closed 9 years ago

splitice commented 9 years ago

1.0.2 is stable now :)

Any chance you could merge with OpenSSL_1_0_2-stable ?

centminmod commented 9 years ago

+1 for that

waves at @splitice

drwetter commented 9 years ago

joining the crowd with +1 :-)

v998 commented 9 years ago

+1 :)

PeterMosmans commented 9 years ago

Hi @splitice , @centminmod , @drwetter , @v998

Thanks for the posts, good to see that the fork is actually useful :) I'm already working on the merges, but due to the giant source code reformat these merges are long and plentiful. As there are plenty of opportunities for bugs to creep in I'd like to handle the merges with care, which takes time.

Please hang on, and the end result will be near soon (I expect this week).

Cheers,

Peter

splitice commented 9 years ago

@PeterMosmans Awesome.

I am well aware of complexities of what you are doing. Its the main reason I am leaving it to an expert like yourself :)

Take your time. I am happy to help test when you are done.

PeterMosmans commented 9 years ago

Please note that I'm still working on it but it is a lot (and I do mean a lot of work). Personally I don't see the advantages (yet) of this huge source code reformat. If it was refactoring, bugfixing or enhancements - yes. But changing whitespaces and brackets around, thereby increasing the chance of errors... Let's hope this improves the future and maintainability if the OpenSSL codebase.

I'll keep you updated.

centminmod commented 9 years ago

Thanks @PeterMosmans much appreciated :)

PeterMosmans commented 9 years ago

Hooray! A few days (and a lot of merging and testing) later it's here! Please find the latest working build at https://github.com/PeterMosmans/openssl/commit/56fc479407ed6291de82130aa425601f4fc99f02 This build passes all tests (see for example https://travis-ci.org/PeterMosmans/openssl ), but as always with OpenSSL I'm not convinced that the tests cover everything. It should be as least as bugfree as the original :)

Enjoy!

drwetter commented 9 years ago

Thx a lot, Peter! Compiled it for Linux (https://github.com/drwetter/testssl.sh/tree/master/openssl-bins/openssl-1.0.2-chacha.pm). 4 more ciphers also.