search

PeterRochford / SkillMetrics

A Python library for calculating and displaying the skill of model predictions against observations.
GNU General Public License v3.0
201 stars 92 forks source link

Fix default markers #38

Open malmans2 opened 1 year ago

malmans2 commented 1 year ago

Close #37

Here is a PR with a solution for #37. Feel free to close this if it's not the right solution!

malmans2 commented 1 year ago

Part of the issue was that color "gray" can not be used. Looks like matplotlib string color+marker only accepts single letters (i.e., matplotlib.colors.BASE_COLORS).

While I was looking at it I made a few changes:

  1. colors and markers are now controlled by global variables, it should make it easier for users to change them
  2. Combinations of marker-colors are repeated if needed (but a warning is raised when that happens)