search

PeterSommerlad / SC22WG21_Papers

My submissions to SC22WG21 C++ ISO/IEC standardization group
43 stars 13 forks source link

p0053 basic_osyncstream's ctor implementaion is wrong #12

Closed yumetodo closed 2 years ago

yumetodo commented 3 years ago

According yo your code, it expecting that std::basic_ostream has default ctor.

https://github.com/PeterSommerlad/SC22WG21_Papers/blob/143a5514f69937d63db8094bc939b8d423a68f89/workspace/p0053_basic_osyncstreambuf/src/syncstream.h#L327-L333 https://github.com/PeterSommerlad/SC22WG21_Papers/blob/143a5514f69937d63db8094bc939b8d423a68f89/workspace/p0053_basic_osyncstreambuf/src/syncstream.h#L347-L359

However, actually, std::basic_ostream doesn't have default ctor. https://timsong-cpp.github.io/cppwp/n4861/ostream.cons#lib:basic_ostream,constructor

PeterSommerlad commented 2 years ago

fixed...