search

PeterStaev / lego-spikeprime-mindstorms-vscode

Helps you connect and work with Lego's SPIKE Prime/MINDSTORMS Robot Inventor hubs
Apache License 2.0
64 stars 22 forks source link

feat: UI enhancements #24

Closed nkarstens closed 3 years ago

nkarstens commented 3 years ago

Adds 3 enhancements that will help new developers use Visual Studio Code to program SPIKE Prime and Lego Mindstorms:

1) Adds common commands to a toolbar in the editor. 2) Adds a command to create the file header from a series of user prompts. 3) Prevents the user from attempting to upload when there is no file.

PeterStaev commented 3 years ago

Hey @nkarstens , thanks for your contribution!

Your changes are ok, but I want to add some polishing touches before merging this (like showing the commands only for python files and if possible to show some only when connected to a hub). Will see to do them before the weekend and push a new version to the market place with this.

nkarstens commented 3 years ago

@PeterStaev That's great, thanks! Another thing that I wasn't quite sure about was how necessary it was to add items to disposables lists. I'm new to TypeScript but thought that automatically freeing resources was common in most modern languages.

PeterStaev commented 3 years ago

@nkarstens , reading VScode docs, they actually say you should manually dispose those :)