search

PeterStaev / nativescript-image-swipe

A NativeScript widget to easily :point_up_2: and :mag: through a list of images
Apache License 2.0
35 stars 21 forks source link

image not fulscreen on ipad #57

Open softwarebam opened 4 years ago

softwarebam commented 4 years ago

can set image width ro height ?

PeterStaev commented 4 years ago

Hey @softwarebam , the image is automatically resized so that it fills in the lowest dimension of the screen. May be you need the same as #25 ?

softwarebam commented 4 years ago

It seem not resize image to fill in the lowest dimension of screen in some devices. I find the issue on iPhone 11 (iOS 13) and iPad air2 (iOS 13) as shown below. 05FD2D60-0D06-42CA-86C2-232A649ECA25

The devices need to change orientation, so the image is resized and fill in the lowest dimension of screen properly.

I use nativescript 6.4.

PeterStaev commented 4 years ago

Is the image high enough resolution? If it is not then it will not work, since the plugin sets the max possible scale to be 1.0: https://github.com/PeterStaev/nativescript-image-swipe/blob/5d0284009c6c34fe7ad113299446cf740ac13039/image-swipe.ios.ts#L274-L277

softwarebam commented 4 years ago

Yes, the image is too small. Is it possible to auto zoom to fill in the lowest dimension of screen?

PeterStaev commented 4 years ago

Currently this is not possible, marking it as an enhancement as it makes sense to have an option to allow such behavior.