search

PeterStaev / nativescript-photo-editor

🎨 Easily edit an image in your NativeScript app (crop, draw, etc)
Apache License 2.0
47 stars 15 forks source link

Not compatible with latest ns version -> short import to correct #24

Closed Serge-SDL closed 4 years ago

Serge-SDL commented 5 years ago

Hi!

the plugin is no more compatible with last ns version because it has a short import of image-source on photo-editor.d.ts -> can you just change import { ImageSource } from "image-source"; to import { ImageSource } from "tns-core-modules/image-source";

thanks!

PeterStaev commented 5 years ago

Hey @Serge-SDL , I am aware that the {N} core team is depreciating those short import paths and are pushing all devs to write the full path which seems ridiculous as you have to type an additional 31 symbols for every import. You can read more details on the suggestions here: https://github.com/NativeScript/NativeScript/issues/4041#issuecomment-465477508

So for the time being I'm not going to take any actions on fixing this, until the core team decides how will they proceed with this. Will leave the issue open until then.

PeterStaev commented 4 years ago

This is now available in the new version of the plugin available in the ProPlugins NPM registry. The code uses the new @nativescript scoped packages.

All future work of this plugin will be available exclusively as part of ProPlugins initiative. So if you want to get the latest updates/fixes/features make sure you subscribe to the service. You get all my plugins plus many of the most used and high quality plugins for a small monthly subscription fee.