search

PeterStaev / nativescript-photo-editor

🎨 Easily edit an image in your NativeScript app (crop, draw, etc)
Apache License 2.0
47 stars 15 forks source link

On iOS the photo editor does not open full screen #28

Closed amarseelam closed 4 years ago

amarseelam commented 4 years ago

On iOS the photo editor does not open full screen, And the photo editor starts to move up and down when using the pen tool. How can I make the photo editor occupy the whole screen? Screen Shot 2019-10-15 at 6 37 40 AM

Serge-SDL commented 4 years ago

Hi! @PeterStaev got the same issue and it's very annoying because it makes the plugin unusable on ios 13 (and 79% of iOS user are now on 13 verison). can you take a look ? can I help on something (unfortunately I dont know IOS languages, but I know nativescript :) )

thanks!

Lelelo1 commented 4 years ago

I found a solution: The ViewController's modalPresentationStyle had to be set to automatic.

(in js):

    /* ... */
    viewController.photoEditorDelegate = _this._delegate;
    viewController.modalPresentationStyle = 0; // <--- here
    frame.topmost().ios.controller.presentViewControllerAnimatedCompletion(viewController, true, null);
PeterStaev commented 4 years ago

This is now available in the new version of the plugin available in the ProPlugins NPM registry.

All future work of this plugin will be available exclusively as part of ProPlugins initiative. So if you want to get the latest updates/fixes/features make sure you subscribe to the service. You get all my plugins plus many of the most used and high quality plugins for a small monthly subscription fee.

Serge-SDL commented 4 years ago

Hi @PeterStaev ! I subsriebed to the ProPlugins NPM registry but I can't install it. I let a message on there https://git.proplugins.org/Tangra/nativescript-photo-editor/issues/1 but got no answer :( I really need the plugin for my clients... can you help me ? thanks

PeterStaev commented 4 years ago

@Serge-SDL , I've responded to your issue in the ProPlugins repo. Please check it out.