PeterTheOne / letterboxd-watchlist-torrent-rss

grabs letterboxd watchlist and turns it into a rss feed of torrent magnet links.
MIT License
18 stars 1 forks source link

Add option to use either magnet or torrent links #13

Open stevygee opened 9 years ago

PeterTheOne commented 9 years ago

(or both as they are available..)

PeterTheOne commented 9 years ago

didn't check in detail, but does this really solve the problem? what if config is set to magnet but there only is a torrent file.. I guess the check should start already when searching for torrents.

stevygee commented 9 years ago

Right now it's just a filter of what type of link to display in feed. If config = magnet and there is only a torrent file, that entry is skipped. I do think it makes sense for both torrent and magnet links to be in the database, so it's not necessary to parse search results again if config is changed.

Some search sites only return one type of link, but it's possible to generate a magnet link out of the torrent info hash, but without tracker info. Additional testing is needed to see if these links result in a working download.

PeterTheOne commented 9 years ago

I see your point. There is one case where this leads to unwanted results: When one tracker is preferred over another because of the number of peers but this torrent is not the desired format (magnet or file) then the torrent is not displayed even though there was a torrent in the desired format.