Fix disabled variants still appearing in variant names array

Peternator7 / strum

A small rust library for adding custom derives to enums

https://crates.io/crates/strum

MIT License

1.8k stars 151 forks source link

Fix disabled variants still appearing in variant names array #369

Closed Tar-Tarus closed 21 hours ago

Tar-Tarus commented 4 months ago

This PR resolves #244

It includes the following changes so far:

Test to check for this issue when using the macro a65a225db6f43a69e798b046f2e0d33dea73b9da
Fix to make sure the generated VARIANTS array only contains variants which are not disabled 8444b6d51a349cff6bc70037a771ba5336912d73

Peternator7 commented 4 months ago

Hi @Tar-Tarus, thanks for the PR. I agree this behavior is inconsistent, but I'm pretty hesitant to make any breaking changes around something pretty core like this without knowing what projects in might break. So let me think about it, but I think we might be locked into this behavior with the current attributes.

In the future, I'd like to make most of the attributes scoped to a specific macro so that this behavior is more flexible

Peternator7 commented 21 hours ago

Closing this because it's too disruptive a breaking change