Peterodox / Plumber

World of Warcraft Character Misc QoL Add-On
https://www.curseforge.com/wow/addons/plumber
GNU General Public License v3.0
11 stars 5 forks source link

Plumber crest count no longer showing on Baganator with v 0.132 #1

Closed Sythr4l closed 1 week ago

Sythr4l commented 9 months ago

Since the latest version of baganator, the plumber crest count feature does not appear on the baganator UI. there are no LUA errors associated with this bug.

lnevo commented 8 months ago

The author suggested anchoring against. Hope this helps. Broken again with Baganator-171-2-gd759ddd.zip

Baganator_BackpackViewFrame.Currency3

Peterodox commented 8 months ago

It's been fixed in our update v1.2.5. Baganator is being actively developed so I'll leave this ticket open in case the issue comes back.

lnevo commented 8 months ago

Confirmed working. Thanks for monitoring the compatibility. Two great addons :)

zeenk commented 5 months ago

Broken again in https://www.curseforge.com/wow/addons/baganator/files/5364983

Fixed now.

lnevo commented 5 months ago

Looks like Baganator_BackpackViewFrame was renamed to Baganator_SingleViewBackpackViewFrame in that version. I changed the instances in Modules/BackpackItemTracker.lua to match and it's working again.

Fernissx commented 4 months ago

The crest count feature isn't showing in the Baganator addon when the bags are sorted using category.

Fernissx commented 4 months ago

Would the author be able to add support for the Baganator category view?

Peterodox commented 4 months ago

Would the author be able to add support for the Baganator category view?

It should be working now :)

Fernissx commented 4 months ago

Awesome. Thank you!!

zeenk commented 1 month ago

https://www.curseforge.com/wow/addons/baganator/files/5747265 (retail version)

In the latest alpha version of Baganator he added a new currency ui + button in the bottom left so it's now causing some overlap issues with plumber bag tracker

Single bag view

2024-09-22_21-19-58

Category view

2024-09-22_21-20-23

Peterodox commented 1 week ago

Hey everyone. Since Baganator already has its own currency tracker, it's advised that you turn off this module in Plumber.

lnevo commented 1 week ago

Will try.... Plumber's view with all crests/caps and flightstone view is so perfect :)

lnevo commented 1 week ago

Ok... if you're referring to the traditional "Add to Backpack" currency. Baganator view on crests has nothing on what Plumber is providing. Maybe I'm missing a setting... having all crests and flightstones in one tooltip is top notch.

lnevo commented 1 week ago

Ok sorry for the spam. Found the feature. Flightstones aren't displayed there at all, and you have to look at everything. Definitely not the same thing.