search

Petersoj / alpaca-java

A Java API for Alpaca, the commission free, algo friendly, stock trading broker. https://alpaca.markets
https://petersoj.github.io/alpaca-java/
MIT License
197 stars 82 forks source link

wrong parameter data type of getHistoricQuotes #14

Closed liulinglll closed 4 years ago

liulinglll commented 4 years ago

the data type of "offset" of getHistoricQuotes(String symbol, LocalDate date, Integer offset, Integer limit) should be Long as its milliseconds. please fix it. thanks

mainstringargs commented 4 years ago

Strange, I'll take a look. It's based on the PolygonAPI which has Integer listed as the parameter type: https://polygon.io/docs/#!/Stocks--Equities/get_v1_historic_quotes_symbol_date

mainstringargs commented 4 years ago

Interesting -- I guess its an error in the Polygon documentation. I've updated and released 4.0.1. Take a look.