search

Petersoj / alpaca-java

A Java API for Alpaca, the commission free, algo friendly, stock trading broker. https://alpaca.markets
https://petersoj.github.io/alpaca-java/
MIT License
198 stars 84 forks source link

Polygon API getHistoricQuotes() implemented incorrectly #34

Closed artur-tamazian closed 4 years ago

artur-tamazian commented 4 years ago

getHistoricQuotes() method body and signature seem wrong. Looks like it was copied from getHistoricTrades() as is and returns wrong data.

mainstringargs commented 4 years ago

Thanks for the tip, will look into it

On Mon, Dec 9, 2019 at 9:03 PM Artur Tamazian notifications@github.com wrote:

getHistoricQuotes() method body and signature seem wrong. Looks like it was copied from getHistoricTrades() as is and returns wrong data.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/mainstringargs/alpaca-java/issues/34?email_source=notifications&email_token=ABVXM4UDZQ44GUJTYTWF47DQX4BHJA5CNFSM4JYXIEAKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H7KQBTQ, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABVXM4VYS53KRLJVL5J6E7DQX4BHJANCNFSM4JYXIEAA .

artur-tamazian commented 4 years ago

Nevermind, I missed the difference between these methods bodies. Seems correct to me now.