New Market Data API upgraded to 5.2

Petersoj / alpaca-java

A Java API for Alpaca, the commission free, algo friendly, stock trading broker. https://alpaca.markets

https://petersoj.github.io/alpaca-java/

MIT License

197 stars 82 forks source link

New Market Data API upgraded to 5.2 #75

Closed jessethouin closed 3 years ago

jessethouin commented 3 years ago

Updated with master, fixed bug in MarketDataWebsocketClient

Petersoj commented 3 years ago

Hey thanks! I'll review this on the weekend.

jessethouin commented 3 years ago

It doesn't work, and I can't figure out why. I've stepped through with the debugger, and AbstractWebsocketClientEndpoint.onMessage never fires. It connects to the ws, but I'm not sure MarketDataWebsocketClient is even sending messages, including auth. I'll keep working on it and update here. For now, don't merge.

jessethouin commented 3 years ago

Ok, good to go. Like the commit message says, alpaca's webservices aren't consistent in their return message types. It may be worth raising a bug to them.

edit: https://forum.alpaca.markets/t/websocket-inconsistencies/2852/2