PetitTournesol / Edgeware

Elsavirus inspired fetishware, built from the ground up to use interchangeable packages for better user experience.
MIT License
130 stars 96 forks source link

Inconsistent behavior of mitosis mode with video popups #20

Open vanmonday01 opened 1 year ago

vanmonday01 commented 1 year ago

Dunno if you are still willing to maintain this, but there's no issue written about this so fuck it i guess

The behavior of mitosis can be devided with three parts, two in start.pyw and one in popup.pyw. The two features defined in start.pyw is as follows:

  1. On the first 'annoyance roll', open a popup. It's never triggered in hibernate mode because it's not a part of it.
    • Because, uh, reasons?
    • I've noticed Fill Drive and Replace Images doesn't triggered in hibernate mode either.
  2. On each 'initiative roll' - a subset of annoyance roll, blocks normal image popups.

The other feature defined in popup.pyw is as follows:

  1. When pressing the submit button, open another image popups.

The first problem is that the mitosis mode doesn't do anything meaningful in hibernate mode. It will continue to block image popups, yet no popup was created. It renders all images kind of useless in hibernate mode.

The next problem is that the video popup also uses popup.pyw. It isn't blocked by initiative roll, so it will continue to show up. And since it's a popup, closing it will also trigger mitosis.

Another small problem (in my opinion) is that the popups created by mitosis never contains video. I mean, they're popups too, so it would make sense to have a chance to show up, isn't it?