search

PetrDlouhy / django-admin-charts

Create beautiful configurable charts from your models and display them on the django-admin index page or on django-admin-tools dashboard. The charts are based on models and criterias defined through admin interface and some chart parameters are configurable in live view.
http://django-admin-charts.readthedocs.org/
Other
132 stars 17 forks source link

hardcoded urls -> reverse urls #53

Closed alvarantson closed 1 year ago

alvarantson commented 1 year ago

Some urls seem to be hardcoded! Should be rewritten to reverse url-s because for an example if you change the main route for all django routes to asd.com/xyz/.... then the app breaks!

PS: might have even more routes hardcoded, not only those shown on the picture!

image

PetrDlouhy commented 1 year ago

@alvarantson I found the only occurence in admin_charts.js and made PR for this: #54 Please, check it and test it. Also, if you know better solution how to overcome the parameter unknown at rendering time than creating blank record in urls.py, please tell.

PetrDlouhy commented 1 year ago

@alvarantson I have released version 1.3.0 where this issue should be fixed. Please check.