Closed j-fu closed 2 years ago
Base: 91.01% // Head: 90.61% // Decreases project coverage by -0.40%
:warning:
Coverage data is based on head (
8ca68c5
) compared to base (92835b5
). Patch coverage: 89.72% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Nice work, Juergen! Many thanks.
Dear Petr, could you tag a release ? I would like to announce this when the better performing version becomes available.
Super, will do.
Done.
On Tue, Sep 27, 2022, 10:40 AM Jürgen Fuhrmann @.***> wrote:
Dear Petr, could you tag a release ? I would like to announce this when the better performing version becomes available.
— Reply to this email directly, view it on GitHub https://urldefense.com/v3/__https://github.com/PetrKryslUCSD/Sparspak.jl/pull/10*issuecomment-1259840692__;Iw!!Mih3wA!D0JSEZKYAtAbqObrLt7EU3ziEQOBGMC-69i70HwAfz1xJtKkbWEnjDd6TpFWie122YoSsrcSTap0QLI-IVk2K56_$, or unsubscribe https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ACLGGWCI4TRVDQEHODZYNILWAMWRFANCNFSM6AAAAAAQUTFMJY__;!!Mih3wA!D0JSEZKYAtAbqObrLt7EU3ziEQOBGMC-69i70HwAfz1xJtKkbWEnjDd6TpFWie122YoSsrcSTap0QLI-IXrwaEd0$ . You are receiving this because you modified the open/close state.Message ID: @.***>
Before:
This PR:
With this PR, the generic implementation is on par with the binary blas/lapack wrt. allocations. Before, their number was prohibitively large for any larger sized problem.
After all, I just rewrote the code from netlib. It is BSD licensed (see https://netlib.org/lapack), so there seems to be no problem including this here.
The results conform to the mantra regarding Julia performance: "In doubt, write your own loop" which worked quite well for me in several situations before.
What is puzzling is that the generic routines are faster than the standard ones (e.g. compare between Float64 and MultiFloat{Float64,1}). However I would not yet jump to conclusions here before seeing more tests with relevant problems.
I think this PR should be implemented before any announcement...