PetrKryslUCSD / Sparspak.jl

Direct solution of large sparse systems of linear algebraic equations in pure Julia
MIT License
37 stars 7 forks source link

Use ones(FT) instead of FT(1.0) #25

Closed j-fu closed 1 year ago

j-fu commented 1 year ago

I am working on enabling sparspak together with the new DynamicQuantities.jl, this will is needed for getting this running.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 28.57% and project coverage change: -10.70 :warning:

Comparison is base (020b13b) 90.27% compared to head (c0b092c) 79.57%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #25 +/- ## =========================================== - Coverage 90.27% 79.57% -10.70% =========================================== Files 15 18 +3 Lines 1831 2184 +353 =========================================== + Hits 1653 1738 +85 - Misses 178 446 +268 ``` | [Impacted Files](https://app.codecov.io/gh/PetrKryslUCSD/Sparspak.jl/pull/25?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Petr+Krysl) | Coverage Δ | | |---|---|---| | [src/SparseSpdMethod/SpkLDLtFactor.jl](https://app.codecov.io/gh/PetrKryslUCSD/Sparspak.jl/pull/25?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Petr+Krysl#diff-c3JjL1NwYXJzZVNwZE1ldGhvZC9TcGtMREx0RmFjdG9yLmps) | `0.00% <0.00%> (ø)` | | | [src/Sparspak.jl](https://app.codecov.io/gh/PetrKryslUCSD/Sparspak.jl/pull/25?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Petr+Krysl#diff-c3JjL1NwYXJzcGFrLmps) | `100.00% <ø> (ø)` | | | [src/SparseSpdMethod/SpkSparseSpdSolver.jl](https://app.codecov.io/gh/PetrKryslUCSD/Sparspak.jl/pull/25?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Petr+Krysl#diff-c3JjL1NwYXJzZVNwZE1ldGhvZC9TcGtTcGFyc2VTcGRTb2x2ZXIuamw=) | `29.59% <29.59%> (ø)` | | | [src/SparseSpdMethod/SpkSparseSpdBase.jl](https://app.codecov.io/gh/PetrKryslUCSD/Sparspak.jl/pull/25?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Petr+Krysl#diff-c3JjL1NwYXJzZVNwZE1ldGhvZC9TcGtTcGFyc2VTcGRCYXNlLmps) | `52.25% <52.25%> (ø)` | | | [src/SparseCSCInterface/SparseCSCInterface.jl](https://app.codecov.io/gh/PetrKryslUCSD/Sparspak.jl/pull/25?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Petr+Krysl#diff-c3JjL1NwYXJzZUNTQ0ludGVyZmFjZS9TcGFyc2VDU0NJbnRlcmZhY2Uuamw=) | `93.20% <75.00%> (+1.08%)` | :arrow_up: | | [src/SparseMethod/SpkLUFactor.jl](https://app.codecov.io/gh/PetrKryslUCSD/Sparspak.jl/pull/25?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Petr+Krysl#diff-c3JjL1NwYXJzZU1ldGhvZC9TcGtMVUZhY3Rvci5qbA==) | `97.54% <100.00%> (ø)` | | | [src/SparseMethod/SpkSparseBase.jl](https://app.codecov.io/gh/PetrKryslUCSD/Sparspak.jl/pull/25?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Petr+Krysl#diff-c3JjL1NwYXJzZU1ldGhvZC9TcGtTcGFyc2VCYXNlLmps) | `89.74% <100.00%> (ø)` | | | [src/SparseSpdMethod/SpkSpdMMOps.jl](https://app.codecov.io/gh/PetrKryslUCSD/Sparspak.jl/pull/25?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Petr+Krysl#diff-c3JjL1NwYXJzZVNwZE1ldGhvZC9TcGtTcGRNTU9wcy5qbA==) | `100.00% <100.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/PetrKryslUCSD/Sparspak.jl/pull/25/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Petr+Krysl)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.