Inconsistent use of IDs between commands

[PetrichorPrecipice]

It seems weird to have edit and delete commands use the index with respect to the list whereas commands involving leave or remark use the employee ID instead. Recommended to change to be consistent with one another.

[nus-se-bot]

Team's Response

Delete command uses employee ID. The edit command uses the index specifically because users may need to change the ID of the edited employee, and thus using the ID of the employee in the edit command may cause confusion.

As the command format matches what is documented in the UG and causes the app to fail gracefully (show an error), this suggestion is low priority, and thus classified as not in scope and can be delivered in future iterations.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

• [x] I disagree

Reason for disagreement: Although this suggestion is low priority, that does not mean it does not affect usage of the app. It seems unintuitive to switch between two different kinds of indexes for different commands, hampering ease of usage.

---