PetroFrolov / vast-video-js

VAST-Ad plugin for HTML5 by video.js
79 stars 33 forks source link

Video JS 4 #20

Closed kefniark closed 10 years ago

kefniark commented 11 years ago

Some times ago, Video JS has updated their video player. Now it's recommanded to use this one (version 4.0) : <link href="http://vjs.zencdn.net/4.0/video-js.css" rel="stylesheet"> <script src="http://vjs.zencdn.net/4.0/video.js">

in place of the old one (version 3.2.0) : <link href="http://vjs.zencdn.net/c/video-js.css" rel="stylesheet"> <script src="http://vjs.zencdn.net/c/video.js"&gt;&lt;/script&gt;

This vast plugin works really well with the old version. But with the new version, the plugin doesn't seems to be correctly initialized : "Uncaught TypeError: Cannot set property 'xdr' of undefined"

Are you planning to update this plugin to support the new Video JS ?

blueone1 commented 11 years ago

I actually see this error, too. I was going crazy trying to figure it out. LOL. I thought I was making a mistake somewhere else.

PetroFrolov commented 11 years ago

Hi! New version of VideoJS has a bug that dosn't allow to work of my plugin correctly. I've posted a it into bugtracker, but it'is hasn't solved yet.

P.S. In v4 VideoJs has a different version of plugins API.

E-P1983 commented 10 years ago

Did you have any chance to fix it yet?

doublex commented 10 years ago

Would be great, if this would work with video-js 4.

PetroFrolov commented 10 years ago

I've added new branch that supports v4 and back compatible with v3. There is no new features. All code was rewrited for new arch of Video.JS.

doublex commented 10 years ago

Thanks a lot! Great extension!

E-P1983 commented 10 years ago

Awesome!!

PetroFrolov commented 10 years ago

Please notify me if that version not works

E-P1983 commented 10 years ago

I will test it tonight and let it know :)

npofopr commented 10 years ago

v4.4 don't work? Or just me?

sebastianlueke commented 10 years ago

@doublex Example didn't show up any ads for me, too. System OS X Maverick Safari and FF latest Versions. Anybody has a working example with v4.4.3 of video.js?