PetrochukM / PyTorch-NLP

Basic Utilities for PyTorch Natural Language Processing (NLP)

https://pytorchnlp.readthedocs.io

BSD 3-Clause "New" or "Revised" License

2.21k stars 257 forks source link

Add support for append_sos #101

Closed wxl1999 closed 4 years ago

wxl1999 commented 4 years ago

Add support for parameter append_sos in SubwordEncoder and StaticTokenizerEncoder #82

codecov-io commented 4 years ago

Codecov Report

Merging #101 into master will decrease coverage by 0.14%. The diff coverage is 81.25%.

@@            Coverage Diff             @@
##           master     #101      +/-   ##
==========================================
- Coverage   94.41%   94.27%   -0.15%     
==========================================
  Files          63       63              
  Lines        1594     1607      +13     
==========================================
+ Hits         1505     1515      +10     
- Misses         89       92       +3

Impacted Files	Coverage Δ
torchnlp/encoders/text/static_tokenizer_encoder.py	`96.15% <80.00%> (-1.77%)`	:arrow_down:
torchnlp/encoders/text/subword_encoder.py	`93.75% <81.81%> (-3.69%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 60112df...143db43. Read the comment docs.

ksopyla commented 4 years ago

Could you merge this PR, append_sos will save me a lot of time :) Thank you in advance

wxl1999 commented 4 years ago

@ksopyla sorry, I don't have permission. The author said he will check recently, but he is very busy...

PetrochukM commented 4 years ago

Thanks for pinging me, I'm starting to look through these PRs. Thanks for your patience!

codecov-commenter commented 4 years ago

Codecov Report

Merging #101 into master will increase coverage by 0.06%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #101      +/-   ##
==========================================
+ Coverage   94.41%   94.47%   +0.06%     
==========================================
  Files          64       64              
  Lines        1611     1629      +18     
==========================================
+ Hits         1521     1539      +18     
  Misses         90       90

Impacted Files	Coverage Δ
torchnlp/encoders/text/static_tokenizer_encoder.py	`98.24% <100.00%> (+0.32%)`	:arrow_up:
torchnlp/encoders/text/subword_encoder.py	`97.91% <100.00%> (+0.48%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cde86ba...0efd59a. Read the comment docs.