search

PetrochukM / PyTorch-NLP

Basic Utilities for PyTorch Natural Language Processing (NLP)
https://pytorchnlp.readthedocs.io
BSD 3-Clause "New" or "Revised" License
2.21k stars 258 forks source link

Untrack hidden directories #18

Closed floscha closed 6 years ago

floscha commented 6 years ago

With the current .gitignore, the Visual Studio Code project settings are tracked with Git as well as the cached word embeddings. This PR adds both of them to .gitignore.

Since IntelliJ IDEA projects are already being ignored, I believe the same should apply to Visual Studio Code projects.

Similarly, the .pretrained_embeddings_cache/ directory is being ignored while .word_vectors_cache/ is not. Is it possible that .pretrained_embeddings_cache/ was renamed to .word_vectors_cache/ at some point during development?

PetrochukM commented 6 years ago

Okay! This makes sense!

Your right about the ".word_vectors_cache/" and ".pretrained_embeddings_cache/".

PetrochukM commented 6 years ago

I deleted .vscode files!