search

PetrochukM / PyTorch-NLP

Basic Utilities for PyTorch Natural Language Processing (NLP)
https://pytorchnlp.readthedocs.io
BSD 3-Clause "New" or "Revised" License
2.21k stars 258 forks source link

snli example broken cause of stack #48

Closed dspoka closed 5 years ago

dspoka commented 6 years ago

Issue Described Here: https://github.com/pytorch/pytorch/issues/6844

codecov-io commented 6 years ago

Codecov Report

Merging #48 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #48   +/-   ##
=======================================
  Coverage   94.05%   94.05%           
=======================================
  Files          56       56           
  Lines        1614     1614           
=======================================
  Hits         1518     1518           
  Misses         96       96

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2d10f0e...e46815b. Read the comment docs.

PetrochukM commented 5 years ago

Hi!

Thanks for your contribution!

This was not quite the right fix, I fixed this problem here: https://github.com/PetrochukM/PyTorch-NLP/pull/56

Thanks!