search

PetrochukM / PyTorch-NLP

Basic Utilities for PyTorch Natural Language Processing (NLP)
https://pytorchnlp.readthedocs.io
BSD 3-Clause "New" or "Revised" License
2.21k stars 258 forks source link

Consider renaming pad_batch to stack_and_pad #59

Closed PetrochukM closed 5 years ago

PetrochukM commented 5 years ago

"pad batch" is not very informative, as if your padding an existing pad, while "stack and pad" follows along the lines of the torch.stack module naming.

PetrochukM commented 5 years ago

Done by https://github.com/PetrochukM/PyTorch-NLP/pull/68