Add GLUE dataset (but still one issue with QQP and SNLI, see comment)

PetrochukM / PyTorch-NLP

Basic Utilities for PyTorch Natural Language Processing (NLP)

https://pytorchnlp.readthedocs.io

BSD 3-Clause "New" or "Revised" License

2.21k stars 258 forks source link

Add GLUE dataset (but still one issue with QQP and SNLI, see comment) #60

Closed PattynR closed 5 years ago

PattynR commented 5 years ago

There is one remaining issue that lies with the dataset itself. The code works for all the datasets except for SNLI and QQP where there are some lines in the data file that contain too much or too little data fields. See my comment in the issue discussion for more explanations. I think that someone that is used to those datasets should be able to know what to do.

PetrochukM commented 5 years ago

Hey There! Sorry for not responding in a while, please update the tests folder to test your changes!

Also, the automated tests are catching a lot of linting errors, please use flake8 and yapf to format your code.

PattynR commented 5 years ago

Hey, no problem! I've added a test file and I've used flake8 to re-format my files, I however have an issue when I try to install Yapf on my computer, but I've run an online PEP8 analyser, and the only warnings left are for too long lines, so I think it should be ok.

PattynR commented 5 years ago

Hey, do I have to open a new pull request, or can you see my changes in this ones? It's the first time I do a pull request so I don't really now how things should go.

PetrochukM commented 5 years ago

Hi! Can you make sure that travis-ci is happy, please?

Also, looked over your code. The module you wrote is gigantic at around 100 line, please break it up (refer to https://en.wikipedia.org/wiki/God_object).

Thanks!

PattynR commented 5 years ago

Ok I'll work on it.