search

Petross404 / testing

testing is a gentoo overlay for my personal, under-development ebuilds
1 stars 0 forks source link

edb-debugger-0.9.21.ebuild rquires Qt5, while Qt4 >= 4.6 would suffice #1

Closed sedimentation-fault closed 7 years ago

sedimentation-fault commented 7 years ago

This is actually not a bug - just an observation regarding the ebuild for the 0.9.21 version of edb-debugger.

The ebuild requires Qt5. However, this is not strictly necessary. Upstream says Qt >= 4.6 should suffice, so I modified the RDEPEND array to:

RDEPEND="
    >=dev-libs/capstone-3.0
    graphviz? ( >=media-gfx/graphviz-2.38.0 )
    >=dev-qt/qtxmlpatterns-4.6
    >=dev-qt/qtgui-4.6
    >=dev-qt/qtcore-4.6
    "

With this modification, edb can be compiled with Qt4 without problems (I have done so with Qt 4.8).

Petross404 commented 7 years ago

@sedimentation-fault Did you gave the user the ability to choose in what Qt version edb is going to be compiled with, via USE flag?

sedimentation-fault commented 7 years ago

No.

I guess most users have either Qt4 or Qt5 installed, not both. So the above will choose the installed Qt, as long as it fulfills the version requirements.

AFAIR even if you have both Qt's installed, the configure script will first check for Qt5 and then for Qt4. So you should be OK without a USE flag for Qt version, even in this case.

My guess is that, since qtxmlpatterns, qtgui and qtcore sufficed to compile edb with Qt4, they will also suffice with Qt5. The other dependencies for Qt5 seem to be pulled in by those 3, so (I guess) they are superfluous. Of course, with only Qt 4.8 installed, I cannot check this claim - but you can. ;-)

Petross404 commented 7 years ago

Many users have both toolkits and if it is to support an older toolkit, then the user should be asked. Qt5 is new and stable and will be the qt version that will be most used in the next few years, but anyway that is what gentoo/pentoo developers also told me.

Also yes these deps might not be necessary but once again, developers insisted that way.

Of course you can modifye the ebuild according your needs :)