PetterS / quickjs

Thin Python wrapper of https://bellard.org/quickjs/
https://github.com/bellard/QuickJS
MIT License
177 stars 19 forks source link

Missing build requirements in pyproject.toml for quickjs==1.13.0 #44

Closed swuecho closed 3 years ago

swuecho commented 3 years ago
Collecting quickjs==1.13.0
  Downloading quickjs-1.13.0.tar.gz (448 kB)
  Installing build dependencies: started
  Installing build dependencies: finished with status 'done'
  WARNING: Missing build requirements in pyproject.toml for quickjs==1.13.0 from https://files.pythonhosted.org/packages/e7/1e/e71aab7c54fadc0fc821f7d0a1a605cde7068717f4117696013b05c29d69/quickjs-1.13.0.tar.gz#sha256=86224f30d7a6183f97af4ae252a338ecf62ef02fd38130b5b8e50e9f988a09a5 (from -r requirements.txt (line 141)).
  WARNING: The project does not specify a build backend, and pip cannot fall back to setuptools without 'wheel'.
PetterS commented 3 years ago

I have never seen this, and I am using quickjs in projects with a pyproject.toml. What is the fix? And when does this occur?

swuecho commented 3 years ago

possible related? https://github.com/pyca/cryptography/pull/4783

seems not related to the quickjs code, but pip problem.

swuecho commented 3 years ago

I could not reproduce it in my dev env too, but in docker build.

FROM python:3.7.7-buster

ENV PIP_DISABLE_PIP_VERSION_CHECK=1
ENV PIP_NO_CACHE_DIR=1

RUN pip install --upgrade pip wheel
RUN pip install quickjs

or clone the debug repo.

https://github.com/swuecho/debug_quickjs_install

PetterS commented 3 years ago

I think the problem is that the pyproject.toml is used at all for building the repo. I am using setup.py when builing. It contains special hacks that are needed to build for Windows.

I should probably exclude the pyproject.toml from the source distribution.

PetterS commented 3 years ago

You can try 1.14.0 now.

swuecho commented 3 years ago

works great. Thanks.