Closed qwenger closed 3 years ago
@PetterS ready for review.
I have now configured CI to build from forks.
Can you push an empty commit? git commit -m Empty --allow-empty
Thank you!
@PetterS just realizing that I did not implement error checking on JS_SetPropertyStr (as in https://github.com/PetterS/quickjs/blob/master/module.c#L618, for example).
Any risk that it ever fails?
It may actually fail for weird strings like the empty string. Also if memory allocation fails. So it may actually be best to add a check for this.
EDIT: strikethrough after testing.
Weird attributes names should be fine, just like you can do
obj["some weird name"] = value;
I started #56 .
Proposal for https://github.com/PetterS/quickjs/issues/54.
Note that the same caveat applies as in https://github.com/PetterS/quickjs/issues/38: dicts and lists cannot be passed directly to
set
:Which is not like
Function.__call__
.