search

PetterS / quickjs

Thin Python wrapper of https://bellard.org/quickjs/
https://github.com/bellard/QuickJS
MIT License
177 stars 19 forks source link

BigNum support #61

Closed qwenger closed 2 years ago

qwenger commented 2 years ago

quickjs is compiled without support for BigInt and friends (CONFIG_BIGNUM in Bellard's code).

Is there a good reason for that? What would it take to add Big[...] support?

PetterS commented 2 years ago

We did not need it when I created the library and thought it was an unnecessary risk. But would probably be possible to enable of your need it

qwenger commented 2 years ago

Thanks for the explanation. I think I can live without it for now (though BigInt has 91% coverage on caniuse.com, so at some point many libraries may start relying on it...).

PetterS commented 2 years ago

At this point I'd probably accept a PR enabling this feature.