PetteriAimonen / focus-stack

Fast and easy focus stacking
MIT License
294 stars 43 forks source link

Request: add --no-align / what algorithm is used for alignment? #28

Open tokiAi opened 2 years ago

tokiAi commented 2 years ago

Hi, would it be possible to add a way to use no alignment to use other alignment algorithms. e.g. as parameter --no-align

Also, could you please tell me which alignment algorithm you use. And possibly add this information to the documentation for others.

PetteriAimonen commented 2 years ago

As mentioned in https://github.com/PetteriAimonen/focus-stack#algorithms-used and https://github.com/PetteriAimonen/focus-stack/blob/master/docs/Algorithms.md, the algorithm used is OpenCV findTransformECC.

So far I have not seen cases where the alignment wouldn't work fairly well. If you have such test cases, please post them somewhere.

tokiAi commented 2 years ago

Ah sorry, I must have overlooked it.

So the parameter would be to test other alignment algorithms. I would like to test whether these bring better results.

PetteriAimonen commented 2 years ago

Any such testing is better done by editing the source code. If some algorithm consistently produces better results, only then is there point considering replacement or option.

mviereck commented 2 years ago

An option --no-align is useful if one has already aligned images and want to compare the stacking results of different stacking tools. It is also useful if one provides a frontend where aligning and stacking are done in different steps and the frontend provides different alignment or stacking tools by choice. (This will be the case in my project once I continue to develop it.)

PetteriAimonen commented 2 years ago

Oh well. Not something I'm interested in adding, but I don't oppose a pull request.