PewePro / alef-tng

Alef strikes back
2 stars 3 forks source link

NoMethodError: undefined method `length' for nil:NilClass #166

Open PewePro opened 8 years ago

PewePro commented 8 years ago

View details in Rollbar: https://rollbar.com/AlefTNG/AlefTNG/items/23/


NoMethodError: undefined method `length' for nil:NilClass
  File "/home/aleftng/deploy/aleftng/shared/bundle/ruby/2.2.0/gems/rinruby-2.0.3/lib/rinruby.rb", line 468, in pull
  File "/home/aleftng/deploy/aleftng/releases/20160328201916/lib/recommender_system/irt_recommender.rb", line 123, in update_table
  File "/home/aleftng/deploy/aleftng/shared/bundle/ruby/2.2.0/gems/rollbar-2.7.1/lib/rails/rollbar_runner.rb", line 104, in eval_runner
  File "/home/aleftng/deploy/aleftng/shared/bundle/ruby/2.2.0/gems/rollbar-2.7.1/lib/rails/rollbar_runner.rb", line 104, in eval
  File "/home/aleftng/deploy/aleftng/shared/bundle/ruby/2.2.0/gems/rollbar-2.7.1/lib/rails/rollbar_runner.rb", line 104, in eval_runner
  File "/home/aleftng/deploy/aleftng/shared/bundle/ruby/2.2.0/gems/rollbar-2.7.1/lib/rails/rollbar_runner.rb", line 41, in module_eval
  File "/home/aleftng/deploy/aleftng/shared/bundle/ruby/2.2.0/gems/rollbar-2.7.1/lib/rails/rollbar_runner.rb", line 41, in eval_runner
  File "/home/aleftng/deploy/aleftng/shared/bundle/ruby/2.2.0/gems/rollbar-2.7.1/lib/rails/rollbar_runner.rb", line 30, in block in run
  File "/home/aleftng/deploy/aleftng/shared/bundle/ruby/2.2.0/gems/rollbar-2.7.1/lib/rails/rollbar_runner.rb", line 47, in rollbar_managed
  File "/home/aleftng/deploy/aleftng/shared/bundle/ruby/2.2.0/gems/rollbar-2.7.1/lib/rails/rollbar_runner.rb", line 30, in run
  File "/home/aleftng/deploy/aleftng/shared/bundle/ruby/2.2.0/gems/rollbar-2.7.1/bin/rollbar-rails-runner", line 5, in <top (required)>
  File "/home/aleftng/deploy/aleftng/shared/bundle/ruby/2.2.0/bin/rollbar-rails-runner", line 23, in load
  File "/home/aleftng/deploy/aleftng/shared/bundle/ruby/2.2.0/bin/rollbar-rails-runner", line 23, in <main>
mlabaj commented 8 years ago

Toto nastalo, ked sa pocitalo irt v Rku, Rko spadlo na tom, ze nema kniznice a potom rinruby nemalo co pullnut.

Chybajuce kniznice som na serveri nainstaloval.

Treba vyriesit jednu vec:

  1. Tie kniznice (stringr a ltm) sa nachadzaju v branchi v adresari lib/stats - tam urcite nemaju co robit (je to adresar pre kod robiaci statistiky aktivity studentov; treba ich odtial dat prec) a ani ich to tam nenajde. Bud ich treba umiestnit tak, aby ich task updatovania tabulky recommendera nasiel (ale mat ich v roote aplikacie nie je dobre - cize skor ich umiestnit na vhodne miesto a kod tam nasmerovat) - alebo, radsej, na vhodne miesto (README.md, to je to, co sa automaticky zobrazuje tu: https://github.com/PewePro/alef-tng ) pridat do casti Installation dalsi krok nasetupovania aplikacie: instalacia Rka, instalacia kniznic (ktorych, prikazy). Po tom sa tento issue moze zavriet. Zmeny robit v branchi score.

A jednu vec premysliet/skontrolovat:

  1. Ked v Rku padaju veci (to som sa pytal davnejsie na Slacku, ci ked spadne prikaz v Rku, tak ci sa to prenesie do ruby) - vysledkom R prikazu bol "Error: ...", tak kod napriek tomu bezal dalej s dalsimi R prikazmi a v ruby to spadlo az vtedy, ked rinruby chcelo nieco pullnut a nema co. Ak ale pad jedneho R prikazu kod nezastavi, potom by sa mohlo stat, ze spadne len cast a rinruby nepozorovane pullne chybne vysledky a tie sa pouziju.

Maly test (vlozil som neexistujuci prikaz), vypise error a bezi to dalej akoby nic (vypis z konzoly z volania update_table pre Irt recommender).

            }
          }
          fail_this__non_existing_command
Error: object 'fail_this__non_existing_command' not found
          #spustenie irt
          library(ltm)
Loading required package: MASS
Loading required package: msm
Loading required package: polycor
Loading required package: mvtnorm
Loading required package: sfsmisc
          model = ltm(result ~ z1, IRT.param = TRUE)

Otazka je, nakolko je to problem, alebo budeme verit tomu R kodu, ze v nom nic nehavaruje a nechceme to reportovat do Rollbaru...

petergaspar commented 8 years ago

@veronikagondova skusala si sa na to uz pozriet?

veronikagondova commented 8 years ago

zatial nie, ale mozem sa na to pozriet cez vikend :)

mlabaj commented 7 years ago

Bump.