Misleading function name: low_pass_filter_space

PeyracheLab / miniscoPy

A package to analyse calcium imaging data recorded with the Miniscope.

GNU General Public License v2.0

32 stars 9 forks source link

Misleading function name: low_pass_filter_space #17

Closed DenisPolygalov closed 6 years ago

DenisPolygalov commented 6 years ago

This function: https://github.com/PeyracheLab/miniscoPy/blob/3ef21f98082e3eae33327b9c2274bc4811926065/miniscopy/base/motion_correction.py#L241

is taken from here: https://github.com/flatironinstitute/CaImAn/blob/0fb81a8fd4b58c0a5b568a5e87e9ce36be980ee9/caiman/motion_correction.py#L1795

but have named in a completely opposite way. From what it does with pictures I can say the original name (high_pass_filter_space) is the correct one. Please rename in order to avoid misleading.

Regards, Denis

DenisPolygalov commented 6 years ago

Seems like this is neither high not low pass filter... So never mind. Closing this.