PeyracheLab / miniscoPy

A package to analyse calcium imaging data recorded with the Miniscope.
GNU General Public License v2.0
32 stars 9 forks source link

Motion correction does not do what it is suppose to do according to description #7

Closed DenisPolygalov closed 6 years ago

DenisPolygalov commented 6 years ago

You have following description for the normcorre() function: """ see Pnevmatikakis, E.A., and Giovannucci A. (2017). NoRMCorre: An online algorithm for piecewise rigid motion correction of calcium imaging data. Journal of Neuroscience Methods, 291:83-92 or CaiMan github """ but this is not correct. All the code for piecewise rigid or non-rigid correction is commented and not used. Only rigid motion correction for the whole frame is used inside. This have nothing to do with the paper mentioned above.

gviejo commented 6 years ago

Hi Denis,

We are currently testing the non-rigid motion correction extensively to be sure that there is no mistake. We should push the new version soon.

Best

Guillaume