search

PezzaD84 / macLAPS

LAPS solution for macOS managed with Jamf
40 stars 10 forks source link

swiftDialog version #14

Closed azgmacos closed 3 months ago

azgmacos commented 9 months ago

hey there, this is overwriting the current version of swiftDialog I have installed each time, can it be removed from the package and built into the script to check for the latest?

PezzaD84 commented 9 months ago

Hi @azgmacos The laps decoder script should be checking for swiftdialog and only installs if needed or an update is needed. Which version of the script are you currently using? Can you share the logs if possible? Thanks

azgmacos commented 9 months ago

This is the latest package downloaded from github….

Built into the actual package (not the script) swiftDialog version 1.11.2 is installing over and over each time as it reinstalls the LAPS package (as shown in the setup guide). Please see screenshot of Jamf setup.

Please see the attached screenshot of suspicious package (on latest version downloaded from Github. For now ,I just made my own branding package and removed the swiftDialog with composer…

Thank you for creating this LAPS solution, I saw your presentation at JNUC and I really liked it!

Also, couple of other smaller feature suggestions (which I did for my own implementation)

  1. Option to set a custom home folder path for the account
  2. Option to hide the account on creation

Hope this is helpful 😊

Subject: [EXTERNAL] Re: [PezzaD84/macOSLAPS] swiftDialog version (Issue #14)

Hi @azgmacoshttps://urldefense.com/v3/__https:/github.com/azgmacos__;!!Ny3gXNNm!4CdULeOxjB12U-RDztbLjuCX9m84300y7xtq6ZfO4hGnSal9ObLszqWo9UuyPqmOeV6ug9ocTjaWdOerOoFsy05R9khr9Wob$ The laps decoder script should be checking for swiftdialog and only installs if needed or an update is needed. Which version of the script are you currently using? Can you share the logs if possible? Thanks

— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/PezzaD84/macOSLAPS/issues/14*issuecomment-1766775180__;Iw!!Ny3gXNNm!4CdULeOxjB12U-RDztbLjuCX9m84300y7xtq6ZfO4hGnSal9ObLszqWo9UuyPqmOeV6ug9ocTjaWdOerOoFsy05R9pPO1SPK$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/BDGZ2SBRHH6K6XGLGUASNGTX72XMRAVCNFSM6AAAAAA6EEEBNGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRWG43TKMJYGA__;!!Ny3gXNNm!4CdULeOxjB12U-RDztbLjuCX9m84300y7xtq6ZfO4hGnSal9ObLszqWo9UuyPqmOeV6ug9ocTjaWdOerOoFsy05R9mcSQdYX$. You are receiving this because you were mentioned.Message ID: @.***>

azgmacos commented 9 months ago
Screenshot 2023-10-17 at 11 36 07 AM Screenshot 2023-10-17 at 11 35 01 AM
PezzaD84 commented 9 months ago

Ahhh I'm with you now! This is my mistake which I've only just seen. The newer version no longer needs the PKG file as the images are now hosted in GitHub. I was updating the wiki page but must have missed the part where I noted the PKG is no longer needed in the new versions.

PezzaD84 commented 9 months ago

Also thanks for checking out my jnuc session it's awesome to hear feedback like this and take feature requests. The option to hide the account is something I've been looking to add but I'm running out of script variables within JAMF for these extras to be added. At the moment you can prefix the account name with an underscore. For example _lapsadmin would create the account hidden.